linux-kernel - Re: [BUGFIX] crypto: Fix ctr(aes) testing by specifying geniv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1250257647.25202.21.camel@localhost>
Date:	Fri, 14 Aug 2009 16:47:27 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Huang Ying <ying.huang@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Subject: Re: [BUGFIX] crypto: Fix ctr(aes) testing by specifying geniv

On Fri, 2009-08-14 at 23:02 +1000, Herbert Xu wrote:
> diff --git a/crypto/ablkcipher.c b/crypto/ablkcipher.c
> index 03fb5fa..f6f0833 100644
> --- a/crypto/ablkcipher.c
> +++ b/crypto/ablkcipher.c
> @@ -183,6 +183,12 @@ EXPORT_SYMBOL_GPL(crypto_givcipher_type);
>  
>  const char *crypto_default_geniv(const struct crypto_alg *alg)
>  {
> +	if (((alg->cra_flags & CRYPTO_ALG_TYPE_MASK) ==
> +	     CRYPTO_ALG_TYPE_BLKCIPHER ? alg->cra_blkcipher.ivsize :
> +					 alg->cra_ablkcipher.ivsize) !=
> +	    alg->cra_blocksize)
> +		return "chainiv";

I guess you used this cryptic construct instead of something more
readable because this is about a crypto algorithms? ;-)

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/