linux-kernel - Re: [PATCH 4/6] new kfifo API v0.3 - add DEFINE_KFIFO and friends, add very tiny functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 14 Aug 2009 10:23:33 -0700
From:	Joe Perches <joe@...ches.com>
To:	Stefani Seibold <stefani@...bold.net>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	Andi Kleen <andi@...stfloor.org>,
	Amerigo Wang <xiyou.wangcong@...il.com>
Subject: Re: [PATCH 4/6] new kfifo API v0.3 - add DEFINE_KFIFO and friends,
 add very tiny functions

On Fri, 2009-08-14 at 19:03 +0200, Stefani Seibold wrote:
> Am Freitag, den 14.08.2009, 08:20 -0700 schrieb Joe Perches:
> > > Add INIT_KFIFO - macro to initialize a with DECLARE_KFIFO declared kfifo 
> > What does the description mean?
> Exactly what it meas. If you declare a kfifo with DECLARE_KIFO than you
> must initialize this fifo which INIT_KFIFO.

I recognize the intent, but you should read the description to
yourself slowly.  It's also the same content in the kerneldoc.

Maybe INIT_KFIFO - Initialize a kfifo declared by DECLARED_KFIFO

> > I think you should mention somewhere that these macros
> > actually define 2 objects.  "name##_buffer" might have
> > unexpected clashes and be prefixed with kfifo.
> > maybe something like "kfifo_##name##_buffer"?
> Maybe name it name##_kfifo_buffer?

Your choice.  I think most kernel use prefers prefixes.

> But before doing this i will wait for more response and for inclusion
> into -mm. If i get an okay i will do a maintainance patch. It is to much
> work to handle this splitted patches.

Fine by me. cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/