linux-kernel - Re: [PATCH tip 1/1] perf record: Fix typo in pid_synthesize_comm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28379.1250276831@turing-police.cc.vt.edu>
Date:	Fri, 14 Aug 2009 15:07:11 -0400
From:	Valdis.Kletnieks@...edu
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH tip 1/1] perf record: Fix typo in pid_synthesize_comm_event

On Fri, 14 Aug 2009 15:26:32 -0300, Arnaldo Carvalho de Melo said:
> We were using 'fd' locally, but there was a global 'fd' too, so when
> converting from open to fopen the test made against fd should be made
> against 'fp', but since we have that global...

If the kernel was -Wshadow safe by default, this sort of thing would happen
less often... :)

Content of type "application/pgp-signature" skipped