linux-kernel - Re: [PATCH 1/2] Use kfifo to buffer USB generic serial writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090814214503.GA9051@cuplxvomd02.corp.sa.net>
Date:	Fri, 14 Aug 2009 14:45:03 -0700
From:	David VomLehn <dvomlehn@...co.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	greg@...ah.com
Subject: Re: [PATCH 1/2] Use kfifo to buffer USB generic serial writes

On Fri, Aug 14, 2009 at 10:20:39PM +0100, Alan Cox wrote:
> > +		spin_lock_irqsave(&port->write_fifo_lock, flags);
> > +		chars = __kfifo_len(port->write_fifo);
> > +		spin_unlock_irqrestore(&port->write_fifo_lock, flags);
> 
> Any reason for not using kfifo_len() ?

Nope. At one time there was a bit more code protected here and when I took it
out, I missed the opportunity to squash it down. I'll incorporate this with
any other changes that come in.

> Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/