linux-kernel - Re: [patch] clockevents_notify() need to be called with irq's enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1250234778.2965.8.camel@sbs-t61>
Date:	Fri, 14 Aug 2009 00:26:18 -0700
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	"mingo@...e.hu" <mingo@...e.hu>, "hpa@...or.com" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
	"Brown, Len" <len.brown@...el.com>
Subject: Re: [patch] clockevents_notify() need to be called with irq's
 enabled

On Thu, 2009-08-13 at 23:05 -0700, Thomas Gleixner wrote:
> On Thu, 13 Aug 2009, Suresh Siddha wrote:
> 
> > From: Suresh Siddha <suresh.b.siddha@...el.com>
> > Subject: clockevents_notify() need to be called with irq's enabled
> > 
> > Currently clockevents_notify() is called with interrupts enabled at some
> > places and interrupts disabled at some other places.
> 
> The only place I can see which calls clockevents_notify with
> interrupts enabled is the hrtimer cpu hotplug code.
> 
> I'm a bit wary to enable interrupts all over the place in sensitive
> corners like ACPI idle code ...
> 
> Why don't we just do the obvious and take clockevents_lock irqsave ?

We didn't go that route because of the smp_call_function() in the cpu
hotplug code. So we can't disable interrupts in that path.

ACPI idle code changes were ok'd by Venki. We did 4 or so hours testing
with our patch. Will do more testing in the coming days.

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/