linux-kernel - Re: [PATCH] Make shr to divide by power of 2 (resend)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090815142652.GA7968@localdomain.by>
Date:	Sat, 15 Aug 2009 17:26:53 +0300
From:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:	"Robert P. J. Day" <rpjday@...shcourse.ca>
Cc:	Jiri Slaby <jirislaby@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Make shr to divide by power of 2 (resend)

On (08/15/09 09:49), Robert P. J. Day wrote:
>   it does seem like a DIV_ROUND_UP would be better but perhaps another
> solution would be to define a meaningful macro name for that
> operation.  if that conversion is going to be done regularly, a macro
> with an informative name might be in order.  if it's a one-shot
> operation, though, not much point.
> 

There are different shr/shl operations in bitblit.c. Like,
cur_height = vc->vc_font.height >> 1
cur_height = (vc->vc_font.height << 1)/3;
c |= c >> 1;
u32 idx = vc->vc_font.width >> 3;
etc.

So I don't think we really need a macros here.

	Sergey

Download attachment "signature.asc" of type "application/pgp-signature" (316 bytes)