linux-kernel - Re: [patch 10/15] add xtime_shift and ntp_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0908151102300.1283@localhost.localdomain>
Date:	Sat, 15 Aug 2009 11:04:29 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Martin Schwidefsky <schwidefsky@...ibm.com>
cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	john stultz <johnstul@...ibm.com>,
	Daniel Walker <dwalker@...o99.com>
Subject: Re: [patch 10/15] add xtime_shift and ntp_error_shift to struct
 timekeeper

On Fri, 14 Aug 2009, Martin Schwidefsky wrote:
>  		timekeeper.xtime_nsec += timekeeper.xtime_interval;
> -		if (timekeeper.xtime_nsec >= (u64)NSEC_PER_SEC << clock->shift) {
> -			timekeeper.xtime_nsec -= (u64)NSEC_PER_SEC << clock->shift;
> +		nsecs = (u64) NSEC_PER_SEC << timekeeper.shift;

Minor nit. I made this a separate u64 variable as nsecs is s64 and
while this signed/unsigned mismatch is probably not hurting in that
context it's still not pretty :)

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/