linux-kernel - Re: [PATCH tip 1/1] perf record: Fix typo in pid_synthesize_comm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090815095638.GC15831@elte.hu>
Date:	Sat, 15 Aug 2009 11:56:38 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	Valdis.Kletnieks@...edu, Peter Zijlstra <peterz@...radead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH tip 1/1] perf record: Fix typo in
	pid_synthesize_comm_event


* Arnaldo Carvalho de Melo <acme@...hat.com> wrote:

> Em Fri, Aug 14, 2009 at 03:07:11PM -0400, Valdis.Kletnieks@...edu escreveu:
> > On Fri, 14 Aug 2009 15:26:32 -0300, Arnaldo Carvalho de Melo said:
> > > We were using 'fd' locally, but there was a global 'fd' too, so when
> > > converting from open to fopen the test made against fd should be made
> > > against 'fp', but since we have that global...
> > 
> > If the kernel was -Wshadow safe by default, this sort of thing 
> > would happen less often... :)
> 
> I would love to have that kind of problem spotted by the compiler, 
> but this is no kernel code, the CFLAGS we use is different than 
> the kernel ones, I guess a patch for tools/perf/ would be gladly 
> accepted by Ingo, but let him say so :-)

Yeah. We are using -Wall and -Wextra right now - but -Wshadow is not 
turned on by them.

Does gcc ignore non-existent warnings or do we have to probe them in 
the Makefile, to support older versions of GCC?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/