linux-kernel - Re: [PATCH RT 8/6] [ARM, WATCHDOG] davinci: include mach/timex.h in davinci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090816140850.GP4302@infomag.iguana.be>
Date:	Sun, 16 Aug 2009 16:08:50 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Kevin Hilman <khilman@...prootsystems.com>
Cc:	Wim Van Sebroeck <wim@...ana.be>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	rt-users <linux-rt-users@...r.kernel.org>,
	linux-arm-kernel@...ts.arm.linux.org.uk,
	Russell King - ARM Linux <linux@....linux.org.uk>
Subject: Re: [PATCH RT 8/6] [ARM, WATCHDOG] davinci: include mach/timex.h
	in davinci_wdt.c

Hi Kevin,

> > On Mon, Aug 10, 2009 at 02:04:31PM -0700, Kevin Hilman wrote:
> >> @@ -86,6 +88,9 @@ static void wdt_enable(void)
> >>  {
> >>  	u32 tgcr;
> >>  	u32 timer_margin;
> >> +	u32 wdt_freq;
> >> +
> >> +	wdt_freq = clk_get_rate(wdt_clk);
> >
> > Much better - and only a minor nit which doesn't deserve a repost -
> > wdt_freq should probably match the return type of clk_get_rate.  IOW
> > unsigned long.
> 
> Wim,
> 
> If you're OK with this, can you queue this one for 2.6.32?

I'm also OK with this. I'll queue it up in my -next tree today or tomorrow.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/