linux-kernel - Re: [RFC][PATCH 2/3] ASoC: OMAP: Make use of DMA channel self linking on OMAP1510

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090817121858.fe80fb95.jhnikula@gmail.com>
Date:	Mon, 17 Aug 2009 12:18:58 +0300
From:	Jarkko Nikula <jhnikula@...il.com>
To:	Janusz Krzysztofik <jkrzyszt@....icnet.pl>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Peter Ujfalusi <peter.ujfalusi@...ia.com>,
	Tony Lindgren <tony@...mide.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-arm-kernel@...ts.arm.linux.org.uk" 
	<linux-arm-kernel@...ts.arm.linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC][PATCH 2/3] ASoC: OMAP: Make use of DMA channel self
 linking on OMAP1510

On Mon, 10 Aug 2009 10:50:04 +0200
Janusz Krzysztofik <jkrzyszt@....icnet.pl> wrote:

> Use newly implemented DMA channel self linking on OMAP1510 like on other OMAP
> models. Remove unnecessary DMA transfer restart from interrupt handler
> routine.
> 
> The interrupt routine used to maintain a period index, originally needed for
> counting up periods up to a full buffer in order to restart the DMA transfer.
> For some time, this counter is also used as a replacement for hardware DMA
> progress counter that has been found unusable on OMAP1510 in case of playback.
> Thus, the period index calculation cannot be omitted completely. However, the
> accuracy of this counter can still suffer from missing DMA interrupts.
> 
> In order to work correctly, it requires patch 1 from this series also applied:
> [RFC][PATCH 1/3] ARM: OMAP: DMA: Add support for DMA channel self linking on OMAP1510
> 
> Created against linux-2.6.31-rc5.
> 
> Tested on Amstrad Delta.
> 
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@....icnet.pl>
> 
Nice to see code to be more uniform across the OMAP's. Note this
depends on patch 1 which touches the arch/arm/plat-omap/dma.c.

Acked-by: Jarkko Nikula <jhnikula@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/