linux-kernel - Re: [PATCH] fs/proc/base.c: fix proc_fault_inject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.00.0908171002060.28933@mail.selltech.ca>
Date:	Mon, 17 Aug 2009 10:06:49 -0700 (PDT)
From:	Vincent Li <macli@....ubc.ca>
To:	Amerigo Wang <xiyou.wangcong@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] fs/proc/base.c: fix proc_fault_inject_write() input
 sanity check

On Mon, 17 Aug 2009, Amerigo Wang wrote:

> On Fri, Aug 14, 2009 at 01:18:40PM -0700, Vincent Li wrote:
> >Remove obfuscated zero-length input check and return -EINVAL instead of -EIO error
> >to make the error message clear to user. Add whitespace stripping. No functionality changes.
> 
> If so, why not introduce a new wrapper which is simply strstrip+simple_strtol?
> Now, at least it has two users.

The first patch I sent used strstrip + strict_strtol, I am not sure if it 
is neccesary.

Vincent Li
Biomedical Research Center
University of British Columbia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/