| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4A89A724.406@zytor.com> Date: Mon, 17 Aug 2009 11:53:24 -0700 From: "H. Peter Anvin" <hpa@...or.com> To: Andi Kleen <andi@...stfloor.org> CC: Ingo Molnar <mingo@...e.hu>, Mark Kelly <mark@...feros.com>, linux-kernel@...r.kernel.org, Florian Fainelli <florian@...nwrt.org>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [patch] x86 CPU detection for RDC On 08/17/2009 11:46 AM, Andi Kleen wrote: > "H. Peter Anvin" <hpa@...or.com> writes: > >> On 08/17/2009 11:08 AM, Ingo Molnar wrote: >>> X86_RDC321X already exists in arch/x86/Kconfig. It should probably >>> grow a 'depends on PCI' rline or so. >>> >> Sounds like it. > > iirc the patch used early pci which is actually self contained > in its header. The main problem was that it didn't use it correctly. > It isn't a matter of if compilation works, it is a matter of if we should even try to probe PCI if the user has explicitly disabled CONFIG_PCI. arch/x86/kernel/cpu/cyrix.c disables its PCI probing if CONFIG_PCI is off, even though it also uses <asm/pci-direct.h>. Given that the benefit of this CPU detection patch is extremely small (all it does it get better information in /proc/cpuinfo) and that blind probing can have disastrous consequences, I would say it should not. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists