| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <87fxbq19qs.fsf@devron.myhome.or.jp> Date: Tue, 18 Aug 2009 05:11:23 +0900 From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> To: Stephen Smalley <sds@...ho.nsa.gov> Cc: Amerigo Wang <amwang@...hat.com>, linux-kernel@...r.kernel.org, esandeen@...hat.com, eteo@...hat.com, eparis@...hat.com, linux-fsdevel@...r.kernel.org, akpm@...ux-foundation.org, viro@...iv.linux.org.uk Subject: Re: [Patch 1/2] selinux: ajust rules for ATTR_FORCE Stephen Smalley <sds@...ho.nsa.gov> writes: >> E.g. mode change has implicit ATTR_CTIME change. So it meant, we should >> check the both of FILE__SETATTR and FILE__WRITE? > > No, just setattr. Ok. >> > ATTR_FORCE is supposed to suppress permission checking altogether, and >> > shouldn't be mixed with multiple attribute changes if some should be >> > subject to permission checks while others should not. >> >> I disagree. In fact, ATTR_FORCE is just used for ATTR_KILL_S[UG]ID, and >> notify_change() is disallowing the mixed ATTR_MODE and ATTR_KILL_*. I >> think it should be enough. > > Ok, then we just need to adjust selinux_inode_setattr to understand that > ATTR_FORCE only means to bypass checking on ATTR_MODE. Ok, sure. I'll try it. Thanks. -- OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists