linux-kernel - Re: [PATCH -next] staging/sep: fix build error & warning & kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090817204209.GA9274@suse.de>
Date:	Mon, 17 Aug 2009 13:42:09 -0700
From:	Greg KH <gregkh@...e.de>
To:	Randy Dunlap <rdunlap@...otime.net>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-next <linux-next@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] staging/sep: fix build error & warning & kconfig

On Mon, Aug 17, 2009 at 01:35:30PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Fix sep_driver build when CONFIG_PCI=n:
> 
> drivers/staging/sep/sep_driver.c:2548: error: implicit declaration of function 'pci_dev_get'

I just merged a patch to fix this a few minutes ago.

> and printk format warning:
> 
> drivers/staging/sep/sep_driver.c:290:
> warning: format '%d' expects type 'int', but argument 2 has type 'long unsigned
>  int'

I think Alan is taking care of this stuff already.

> Also, the default kconfig value should not be 'y'.
> 
> And something should be done about this warning (but I didn't fix it):
> drivers/staging/sep/sep_driver.c:1780: warning: 'error' may be used uninitialized in this function

Alan has already resolved this one.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/