linux-kernel - Re: clocksource changes in 2.6.31

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0908172233400.2782@localhost.localdomain>
Date:	Mon, 17 Aug 2009 22:44:16 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Stephen Hemminger <shemminger@...tta.com>
cc:	john stultz <johnstul@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: clocksource changes in 2.6.31 - possible regression

Stephen,

On Mon, 17 Aug 2009, Stephen Hemminger wrote:
> > 
> cat /sys/devices/system/clocksource/clocksource0/available_clocksource
> 
> acpi_pm jiffies tsc 

Hmm. So while your dmesg does not tell anything about the TSC being
unreliable, it's listed as the worst clocksource of all.

The missing dmesg output is not really suprising, see patch below.

Thanks,

	tglx
---
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 71f4368..e254bc0 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -761,7 +761,7 @@ void mark_tsc_unstable(char *reason)
 {
 	if (!tsc_unstable) {
 		tsc_unstable = 1;
-		printk("Marking TSC unstable due to %s\n", reason);
+		printk(KERN_NOTICE "Marking TSC unstable due to %s\n", reason);
 		/* Change only the rating, when not registered */
 		if (clocksource_tsc.mult)
 			clocksource_change_rating(&clocksource_tsc, 0);
@@ -815,6 +815,8 @@ static void __init check_system_tsc_reliable(void)
  */
 __cpuinit int unsynchronized_tsc(void)
 {
+	int unstable = tsc_unstable;
+
 	if (!cpu_has_tsc || tsc_unstable)
 		return 1;
 
@@ -832,10 +834,10 @@ __cpuinit int unsynchronized_tsc(void)
 	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) {
 		/* assume multi socket systems are not synchronized: */
 		if (num_possible_cpus() > 1)
-			tsc_unstable = 1;
+			unstable = 1;
 	}
 
-	return tsc_unstable;
+	return unstable;
 }
 
 static void __init init_tsc_clocksource(void)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/