linux-kernel - Re: [PATCH -next] trace_skb: fix build when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090817230654.GC16222@elte.hu>
Date:	Tue, 18 Aug 2009 01:06:54 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	David Miller <davem@...emloft.net>
Cc:	randy.dunlap@...cle.com, linux-kernel@...r.kernel.org,
	linux-next@...r.kernel.org, akpm@...ux-foundation.org,
	nhorman@...driver.com, rostedt@...dmis.org
Subject: Re: [PATCH -next] trace_skb: fix build when CONFIG_NET is not
	enabled


* David Miller <davem@...emloft.net> wrote:

> From: Randy Dunlap <randy.dunlap@...cle.com>
> Date: Mon, 17 Aug 2009 13:37:36 -0700
> 
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> > 
> > Fix trace_skb_sources build when CONFIG_NET is not enabled:
> > 
> > kernel/built-in.o: In function `probe_skb_dequeue':
> > trace_skb_sources.c:(.text+0xd9152): undefined reference to `init_net'
> > trace_skb_sources.c:(.text+0xd9188): undefined reference to `dev_get_by_index'
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Applied, thanks Randy.

... but these are the wrong patches, they should be removed or 
reverted and redone properly.

It's not just about keeping kernel/trace/* changes in the tracing 
tree (which we can relax on-demand given agreement), it's that 
these patches are also _wrong_ and we cannot relax anything about 
that.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/