lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090817232937.GK24885@sequoia.sous-sol.org>
Date:	Mon, 17 Aug 2009 16:29:37 -0700
From:	Chris Wright <chrisw@...s-sol.org>
To:	Faidon Liambotis <paravoid@...ian.org>
Cc:	Chris Wright <chrisw@...s-sol.org>,
	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	David Woodhouse <David.Woodhouse@...el.com>,
	Suresh Siddha <suresh.b.siddha@...el.com>
Subject: Re: [regression, bisected] fails to boot on Dell Optiplex 760 with
	VT-d enabled

* Faidon Liambotis (paravoid@...ian.org) wrote:
> As an observation, David's patch is checking if *both* iommu->cap and
> iommu->ecap are -1, while yours checks for either. You're also checking
> for ver. Obviously, I have no idea which of the two is more correct.

David's looks fine to me, and as a bonus it's already queued up ;-)
None of those registers should return -1.

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ