linux-kernel - Re: [PATCH] tracing, sched: mark preempt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090818103853.GB5231@nowhere>
Date:	Tue, 18 Aug 2009 12:38:54 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing, sched: mark preempt_schedule() notrace

On Tue, Aug 18, 2009 at 04:01:57PM +0800, Lai Jiangshan wrote:
> 
> Current preempt_schedule() is not marked notrace. It may be
> infinite recursion in __trace_graph_return().
> 
> preempt_schedule()
>   __trace_graph_return()
>     ftrace_preempt_disable() (!!return false!!)
>     ftrace_preempt_enable()
>       preempt_enable_notrace()
>          preempt_schedule() (need_resched() may be true again)



It would happen in __trace_graph_return() , when preempt_schedule()
has finished its job. It's very unlikely the TIF_NEED_RESCHED is
set just after (because it has just been cleared).
But why not. In that case, preempt_schedule() is called again but it's
not a real tracing recursion.

That seems like a normal behaviour actually.

 
> 
> It hardly happens, but marking preempt_schedule() notrace
> makes it safer.
> 
> One interesting thing is that preempt_schedule() is in
> the blacklist of kprobe subsystem. "__kprobes" implies "notrace".
> But preempt_schedule() cannot be marked __kprobes for it
> has been marked __sched. It is in the blacklist makes me
> consider this: should it be marked "notrace" -- YES.
> 
> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
> ---
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 5184580..2e9e209 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -5534,7 +5534,7 @@ out:
>   * off of preempt_enable. Kernel preemptions off return from interrupt
>   * occur there and call schedule directly.
>   */
> -asmlinkage void __sched preempt_schedule(void)
> +asmlinkage void __sched notrace preempt_schedule(void)
>  {
>  	struct thread_info *ti = current_thread_info();
>  
> 
> 
> 
> 
> 
> 
>      
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/