linux-kernel - Re: [Patch] proc: drop write permission on 'timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090818120032.GA22152@localhost>
Date:	Tue, 18 Aug 2009 20:00:32 +0800
From:	Wu Fengguang <fengguang.wu@...el.com>
To:	Amerigo Wang <amwang@...hat.com>
Cc:	Li Zefan <lizf@...fujitsu.com>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Vegard Nossum <vegard.nossum@...il.com>,
	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>,
	Thomas Gleixner <tglx@...utronix.de>, linux-mm@...ck.org,
	David Rientjes <rientjes@...gle.com>,
	Matt Mackall <mpm@...enic.com>,
	Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [Patch] proc: drop write permission on 'timer_list' and
	'slabinfo'

On Tue, Aug 18, 2009 at 11:08:30AM +0800, Amerigo Wang wrote:

> -	proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations);
> +	proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);

Style nitpick. The spaces were packed to fit into 80-col I guess.


ERROR: space required after that ',' (ctx:VxV)
#10: FILE: mm/slub.c:4729:
+       proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
                              ^

ERROR: space required after that ',' (ctx:VxV)
#10: FILE: mm/slub.c:4729:
+       proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
                                      ^

ERROR: space required after that ',' (ctx:VxO)
#10: FILE: mm/slub.c:4729:
+       proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
                                           ^

ERROR: space required before that '&' (ctx:OxV)
#10: FILE: mm/slub.c:4729:
+       proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
                                            ^

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/