linux-kernel - Re: [PATCH 1/2] cs5535-gpio: add AMD CS5535/CS5536 GPIO driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090818004325.2c44e3ee@mycelium.queued.net>
Date:	Tue, 18 Aug 2009 00:43:25 -0400
From:	Andres Salomon <dilinger@...labora.co.uk>
To:	Tobias_Mueller@...m.info
Cc:	David Brownell <david-b@...bell.net>, akpm@...ux-foundation.org,
	Randy Dunlap <randy.dunlap@...cle.com>, deepak@...top.org,
	Takashi Iwai <tiwai@...e.de>, linux-kernel@...r.kernel.org,
	linux-geode@...ts.infradead.org, jordan@...micpenguin.net,
	cjb@...top.org
Subject: Re: [PATCH 1/2] cs5535-gpio: add AMD CS5535/CS5536 GPIO driver  
 support

On Sat, 15 Aug 2009 12:59:48 +0200
Tobias Müller <Tobias_Mueller@...m.info> wrote:

> 2009/7/2 David Brownell <david-b@...bell.net>:
> > Correct-but-annoying ... and maybe worth changing.  The
> > direction *displayed* may not reflect the actual hardware
> > until after that GPIO signal is initialized.  Boot firmware
> > may well have set the direction; Linux shouldn't change it
> > without explicit instructions to do so.
> OK. If this is a know problem with all GPIO drivers, we can
> skip these to two lines to set in pin a defined state.
> 
> > So it would be nice to remove the heuristic.  The best
> > way would be to add a new method to query gpio direction.
> > Then that when it's available, instead of the heuristic.
> This can be implemented when the GPIO interface supports it.
> 
> The problem with the mask still occurs. I changed to default
> mask to 0x0F7FFFFF, so that all pins except the reserved
> ones and the power-pin (which needs special handling) are
> enabled. Shall we keep it this way (which I prefer) or delete
> it entirely?
> 

Hi Tobias,

At this point, I've lost track of all the changes that need to be
made.  Would you mind submitting your current patch w/ all of the
updates we talked about, and we can go from there?  If possible, it'd
be nice to get the cs5535-gpio stuff into the next merge window (but
we'd need to get moving on this now in order to do that).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/