linux-kernel - Re: [PATCH] MFD AB3100 OTP readout v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63386a3d0908190000m483c50edo761261e199492839@mail.gmail.com>
Date:	Wed, 19 Aug 2009 09:00:57 +0200
From:	Linus Walleij <linus.ml.walleij@...il.com>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MFD AB3100 OTP readout v2

2009/8/19 Samuel Ortiz <sameo@...ux.intel.com>:

> I still dont get why you want that to be a device by its own.

Mainly two things:

- The AB3100 HW is partitioned into different logical blocks, one deals with
  battery charging, one with LEDs etc, and one partition is OTP. Doing
  a platform device for each gives a 1-1 match between spec and HW.

> Having a no-op for ab3100_otp_probe() when AB3100_OTP is not defined would be
> a lighter solution, wouldn't it ?

Yep at the cost of an extra .h file for the interface.

No problem though, I'll cook up a v3 the way you want it, it's no
big issue...

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/