linux-kernel - Re: [PATCH v2] [ARM] Kirkwood: Marvell OpenRD-Base board support added to v2.6.31-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A8C02E9.2090701@einfochips.com>
Date:	Wed, 19 Aug 2009 19:19:29 +0530
From:	Dhaval Vasa <dhaval.vasa@...fochips.com>
To:	Simon Kagstrom <simon.kagstrom@...insight.net>
CC:	nico@....org, linux-kernel@...r.kernel.org, rabeeh@...vell.com,
	linux-arm-kernel@...ts.arm.linux.org.uk
Subject: Re: [PATCH v2] [ARM] Kirkwood: Marvell OpenRD-Base board support
 added to v2.6.31-rc5

Simon Kagstrom wrote:
> Hi Dhaval!
> 
> On Mon, 10 Aug 2009 17:37:34 +0530
> Dhaval Vasa <dhaval.vasa@...fochips.com> wrote:
> 
>> reference:
>> http://open-rd.org
>> http://code.google.com/p/openrd
>>
>> This patch is tested for:
>> 1. Boot from DRAM/NAND flash
>> 2. NAND read/write/erase
>> 3. GbE0
>> 4. USB read/write
>>
>> FIXME:
>> 1. SD/UART1 selection
>> 2. MPP configuration (currently, default)
>> 3. PEX
>>
>> Signed-off-by: Dhaval Vasa <dhaval.vasa@...fochips.com>
> 
> Tested-by: Simon Kagstrom <simon.kagstrom@...insight.net>
> 
>> +static unsigned int openrd_base_mpp_config[] __initdata = {
>> +	MPP29_GPIO,	
>                    ^^^^^
> There is trailing whitespace on this line
> 

Nicolas has already applied this patch on his orion tree; it would be 
worth generating separate one for whitespace ?  Suggest.

> Also, I'd suggest merging "[PATCH v2] Kirkwood: Initialise SATA for
> OpenRD-Base" into this one and resubmit it.

Nicolas has already applied this patch on his orion tree.  Should I 
re-submit now ?

> 
> In my patch, I also called kirkwood_i2c_init (see below), which at
> least make the I2C bus appear (not that I've tested it very much).
> 
> // Simon
> 
> diff --git a/arch/arm/mach-kirkwood/openrd_base-setup.c b/arch/arm/mach-kirkwood/openrd_base-setup.c
> index f9a2166..dc0a2fe 100644
> --- a/arch/arm/mach-kirkwood/openrd_base-setup.c
> +++ b/arch/arm/mach-kirkwood/openrd_base-setup.c
> @@ -71,6 +71,8 @@ static void __init openrd_base_init(void)
>         kirkwood_ge00_init(&openrd_base_ge00_data);
>         kirkwood_sata_init(&openrd_base_sata_data);
>         kirkwood_sdio_init(&openrd_base_mvsdio_data);
> +
> +       kirkwood_i2c_init();
>  }
>  
>  MACHINE_START(OPENRD_BASE, "Marvell OpenRD Base Board")
> 
> 

Can you point me to your patch ?

- Dhaval
-- 
_____________________________________________________________________
Disclaimer: This e-mail message and all attachments transmitted with it
are intended solely for the use of the addressee and may contain legally
privileged and confidential information. If the reader of this message
is not the intended recipient, or an employee or agent responsible for
delivering this message to the intended recipient, you are hereby
notified that any dissemination, distribution, copying, or other use of
this message or its attachments is strictly prohibited. If you have
received this message in error, please notify the sender immediately by
replying to this message and please delete it from your computer. Any
views expressed in this message are those of the individual sender
unless otherwise stated.Company has taken enough precautions to prevent
the spread of viruses. However the company accepts no liability for any
damage caused by any virus transmitted by this email.
_____________________________________________________________________
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/