linux-kernel - Re: [PATCH 03/24] io-controller: Common flat fair queuing code in elevaotor layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090819183942.GC4391@redhat.com>
Date:	Wed, 19 Aug 2009 14:39:42 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Gui Jianfeng <guijianfeng@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org,
	containers@...ts.linux-foundation.org, dm-devel@...hat.com,
	jens.axboe@...cle.com, ryov@...inux.co.jp,
	balbir@...ux.vnet.ibm.com, righi.andrea@...il.com,
	nauman@...gle.com, dpshah@...gle.com, lizf@...fujitsu.com,
	mikew@...gle.com, fchecconi@...il.com, paolo.valente@...more.it,
	fernando@....ntt.co.jp, s-uchida@...jp.nec.com, taka@...inux.co.jp,
	jmoyer@...hat.com, dhaval@...ux.vnet.ibm.com,
	m-ikeda@...jp.nec.com, agk@...hat.com, akpm@...ux-foundation.org,
	peterz@...radead.org, jmarchan@...hat.com
Subject: Re: [PATCH 03/24] io-controller: Common flat fair queuing code in
	elevaotor layer

On Wed, Aug 19, 2009 at 11:36:22AM +0800, Gui Jianfeng wrote:
> Vivek Goyal wrote:
> ...
> 
> > +
> > +static void elv_preempt_queue(struct request_queue *q, struct io_queue *ioq)
> > +{
> > +	elv_log_ioq(q->elevator->efqd, ioq, "preempt");
> > +	elv_slice_expired(q);
> > +
> > +	/*
> > +	 * Put the new queue at the front of the of the current list,
> > +	 * so we know that it will be selected next.
> > +	 */
> > +
> > +	requeue_ioq(ioq);
> > +	ioq->slice_start = ioq->slice_end = 0;
> 
> I think this assignment is redundant because these two members will be reset
> when this ioq is scheduled.
> 
> Signed-off-by: Gui Jianfeng <guijianfeng@...fujitsu.com>

thanks Gui. Queued for next posting.

Vivek

> ---
>  block/elevator-fq.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/block/elevator-fq.c b/block/elevator-fq.c
> index d04e925..b3c387d 100644
> --- a/block/elevator-fq.c
> +++ b/block/elevator-fq.c
> @@ -2650,7 +2650,6 @@ static void elv_preempt_queue(struct request_queue *q, struct io_queue *ioq)
>  		 */
>  
>  		requeue_ioq(ioq);
> -		ioq->slice_start = ioq->slice_end = 0;
>  		elv_mark_ioq_slice_new(ioq);
>  	}
>  }
> -- 
> 1.5.4.rc3
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/