linux-kernel - Re: [PATCH 2/3] Add rfkill support to compal-laptop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1250707376.8073.4.camel@johannes.local>
Date:	Wed, 19 Aug 2009 20:42:56 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Mario Limonciello <Mario_Limonciello@...l.com>
Cc:	cezary.jackiewicz@...il.com, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH 2/3] Add rfkill support to compal-laptop

On Wed, 2009-08-19 at 13:36 -0500, Mario Limonciello wrote:
> Signed-off-by: Mario Limonciello <Mario_Limonciello@...l.com>
> Reviewed-by: Alan Jenkins <alan-jenkins@...fmail.co.uk>

> +	ret = setup_rfkill();
> +	if (ret)
> +		goto fail_rfkill;
> +
>  	printk(KERN_INFO "compal-laptop: driver "COMPAL_DRIVER_VERSION
>  		" successfully loaded.\n");
>  
>  	return 0;
>  
> +fail_rfkill:
>  fail_platform_device2:

Isn't that missing sysfs_remove_group()?

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)