linux-kernel - Re: [PATCH -next] net: fix ks8851 build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090818.201200.69809801.davem@davemloft.net>
Date:	Tue, 18 Aug 2009 20:12:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	randy.dunlap@...cle.com
Cc:	sfr@...b.auug.org.au, netdev@...r.kernel.org,
	akpm@...ux-foundation.org, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] net: fix ks8851 build errors

From: Randy Dunlap <randy.dunlap@...cle.com>
Date: Tue, 18 Aug 2009 15:27:05 -0700

> --- linux-next-20090818.orig/drivers/net/Kconfig
> +++ linux-next-20090818/drivers/net/Kconfig
> @@ -1733,6 +1733,8 @@ config KS8851
>         tristate "Micrel KS8851 SPI"
>         depends on SPI
>         select MII
> +	select CRC32
> +	select BITREVERSE
>         help
>           SPI driver for Micrel KS8851 SPI attached network chip.
>  

CRC32 alone is sufficient, because it, in turn, selects BITREVERSE

When you resubmit with this simplification, I'll apply the
patch to net-2.6 since the problem exists in Linus's tree
too, not just -next.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/