linux-kernel - [PATCH 13/15] sched: Detect child domain of NUMA (aka NODE) domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090820134347.GB29327@alberich.amd.com>
Date:	Thu, 20 Aug 2009 15:43:47 +0200
From:	Andreas Herrmann <andreas.herrmann3@....com>
To:	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...e.hu>
CC:	linux-kernel@...r.kernel.org
Subject: [PATCH 13/15] sched: Detect child domain of NUMA (aka NODE) domain


On multi-node processors a NUMA node might not span a socket.
Instead a socket might span several NUMA nodes.

This patch introduces a check whether NODE domain is parent
of MC domain and sets s_data.numa_child_level accordingly.
(See previous patch for further details.)

Signed-off-by: Andreas Herrmann <andreas.herrmann3@....com>
---
 kernel/sched.c |   43 +++++++++++++++++++++++++++++++++++++++++--
 1 files changed, 41 insertions(+), 2 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index b03701d..0c950dc 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -8869,6 +8869,45 @@ static void build_sched_groups(struct s_data *d, enum sched_domain_level l,
 	}
 }
 
+static enum sched_domain_level get_numa_child_domain_level(struct s_data *d,
+	const struct cpumask *cpu_map)
+{
+	enum sched_domain_level dl = SD_LV_NONE;
+#ifdef CONFIG_NUMA
+	int i;
+	int proper_superset = 0;
+	int proper_subset = 0;
+
+	for_each_cpu(i, cpu_map) {
+		cpumask_and(d->tmpmask, cpu_map, topology_cpu_node_cpumask(i));
+		cpumask_and(d->nodemask, cpu_map,
+			    cpumask_of_node(cpu_to_node(i)));
+
+		/* NUMA node's CPU set is proper subset of socket's CPU set */
+		if (cpumask_subset(d->nodemask, d->tmpmask) &&
+		    !cpumask_subset(d->tmpmask, d->nodemask))
+			proper_subset = 1;
+
+		/* socket's CPU set is proper subset of NUMA node's CPU set */
+		if (!cpumask_subset(d->nodemask, d->tmpmask) &&
+		    cpumask_subset(d->tmpmask, d->nodemask))
+			proper_superset = 1;
+	}
+
+	if (proper_subset && proper_superset)
+		printk(KERN_ERR "sched: inconsistent NUMA hierarchy\n");
+	else if (proper_subset) {
+		printk(KERN_DEBUG "sched: NUMA child domain: MC\n");
+		dl = SD_LV_MC;
+	} else {
+		printk(KERN_DEBUG "sched: NUMA child domain: CPU\n");
+		dl = SD_LV_CPU;
+	}
+
+#endif
+	return dl;
+}
+
 /*
  * Build sched domains for a given set of cpus and attach the sched domains
  * to the individual cpus
@@ -8881,13 +8920,13 @@ static int __build_sched_domains(const struct cpumask *cpu_map,
 	struct sched_domain *sd;
 	int i;
 
-	d.numa_child_level = SD_LV_NONE;
-
 	alloc_state = __visit_domain_allocation_hell(&d, cpu_map);
 	if (alloc_state != sa_rootdomain)
 		goto error;
 	alloc_state = sa_sched_groups;
 
+	d.numa_child_level = get_numa_child_domain_level(&d, cpu_map);
+
 	/*
 	 * Set up domains for cpus specified by the cpu_map.
 	 */
-- 
1.6.0.4



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/