linux-kernel - Re: [RFC v6][PATCH 2/4] intel_txt: Intel(R) TXT reboot/halt shutdown support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A8D743D.6000504@zytor.com>
Date:	Thu, 20 Aug 2009 09:05:17 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"Wang, Shane" <shane.wang@...el.com>
CC:	Ingo Molnar <mingo@...e.hu>,
	"Cihula, Joseph" <joseph.cihula@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"arjan@...ux.intel.com" <arjan@...ux.intel.com>,
	"andi@...stfloor.org" <andi@...stfloor.org>,
	"chrisw@...s-sol.org" <chrisw@...s-sol.org>,
	"jmorris@...ei.org" <jmorris@...ei.org>,
	"jbeulich@...ell.com" <jbeulich@...ell.com>,
	"peterm@...hat.com" <peterm@...hat.com>,
	"Wei, Gang" <gang.wei@...el.com>
Subject: Re: [RFC v6][PATCH 2/4] intel_txt: Intel(R) TXT reboot/halt	shutdown
 support

On 08/20/2009 02:33 AM, Wang, Shane wrote:
> Hi Ingo & hpa,
> 
> I have made some change on the previous tboot patch to fix the build errors.
> Please comment.
> 
> Thanks.
> Shane
> 

This code addresses the build errors, but not in the right manner.

We should not have to have tboot-specific #ifdefs in tons and tons of
arch-generic files; we need to figure out how to move them into code
flow already in arch-specific code, or we need to very carefully figure
out what additional arch-specific operations are needed at a higher level.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/