linux-kernel - Re: [PATCH 4/7] kfifo: rename kfifo_put... into kfifo_in... and kfifo_get... into kfifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090820161147.GB29994@basil.fritz.box>
Date:	Thu, 20 Aug 2009 18:11:47 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Stefani Seibold <stefani@...bold.net>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	Andi Kleen <andi@...stfloor.org>,
	Amerigo Wang <xiyou.wangcong@...il.com>
Subject: Re: [PATCH 4/7] kfifo: rename kfifo_put... into kfifo_in... and
	kfifo_get... into kfifo_out...

On Wed, Aug 19, 2009 at 02:03:39PM -0700, Joe Perches wrote:
> On Wed, 2009-08-19 at 23:00 +0200, Stefani Seibold wrote:
> > rename kfifo_put... into kfifo_in... to prevent miss use of old non in kernel-tree drivers
> > ditto for kfifo_get... -> kfifo_out...
> 
> I would have thought
> 	kfifo_put -> kfifo_out
> 	kfifo_get -> kfifo_in
> but maybe that's just me.

I don't think it's fruitful to criticize other people's variable
names. The rule in Linux is normally: if you write the code
you get to name it the way you want.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/