linux-kernel - Re: [PATCHv2 2/3] Regulator: Add TPS6507x regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090820183817.GA5032@sirena.org.uk>
Date:	Thu, 20 Aug 2009 19:38:18 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Anuj Aggarwal <anuj.aggarwal@...com>
Cc:	lrg@...mlogic.co.uk, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, felipe.balbi@...ia.com,
	tony@...mide.com, linux-i2c@...r.kernel.org
Subject: Re: [PATCHv2 2/3] Regulator: Add TPS6507x regulator driver

On Thu, Aug 20, 2009 at 07:20:30PM +0530, Anuj Aggarwal wrote:

One very minor issue:

> +struct tps_pmic {
> +	struct regulator_desc desc[TPS6507X_NUM_REGULATOR];
> +	struct i2c_client *client;
> +	struct regulator_dev *rdev[TPS6507X_NUM_REGULATOR];
> +	struct tps_info *info[TPS6507X_NUM_REGULATOR];

This should be const struct tps_info * since the table of tps_info
structs that this points into is const; otherwise you'll get warnings
from at least sparse.

Otherwise this looks good - I'd be happy to ack this with a followup
patch fixing this issue.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/