linux-kernel - Re: [PATCH] x86: add /proc/cpuinfo/physical id quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1250803348.2754.26.camel@sbs-t61.sc.intel.com>
Date:	Thu, 20 Aug 2009 14:22:28 -0700
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Alex Chiang <achiang@...com>, "hpa@...or.com" <hpa@...or.com>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: add /proc/cpuinfo/physical id quirks

On Thu, 2009-08-20 at 14:03 -0700, Andi Kleen wrote:
> > I am leaning towards sysfs, and prefer:
> > 
> >  	/sys/devices/system/cpu/$cpu/chassis_id
> > 
> > How does that sound?
> 
> I would prefer to simply use the existing physical id for this like
> in your original patch.  We already have a bewildering zoo of different
> CPU IDs, no need to increase the confusion even more.
> 
> Incidentially mcelog already knows how to use physical ID for this,
> would need to be changed for a new sysfs interface

Andi, Based on our past experiences, I am nervous if there are some
software/firmware interactions that can negatively affect the cpu
topology detection.

If we really think overloading the "physical id" helps with existing
software, then I am ok with changing the user visible part of the /proc/
or /sys files but not with the kernel's per cpu info's phys_proc_id,
which is used for topology detection etc.

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/