linux-kernel - [PATCH 0/1] aoe: ensure we initialise the request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1250872904-10993-1-git-send-email-apw@canonical.com>
Date:	Fri, 21 Aug 2009 17:41:43 +0100
From:	Andy Whitcroft <apw@...onical.com>
To:	"Ed L. Cashin" <ecashin@...aid.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...onical.com>,
	linux-kernel@...r.kernel.org
Cc:	Andy Whitcroft <apw@...onical.com>
Subject: [PATCH 0/1] aoe: ensure we initialise the request_queue correctly

We have been seeing oopses in very recent kernels when using the AOE driver.
When attempting to mount remote devices we get a warning from the kobject
layer:

  [ 2645.959090] kobject '<NULL>' (ffff880059ca22c0): tried to add
	an uninitialized object, something is seriously wrong.

Looking at the driver it seems to have always had an embedded request_queue
and it is this that is throwing the error.  It appears the intent is
tha these would be allocated and released using helpers, and the lack of
these leaves the object uninitialised and throws the error.  It is unclear
how this could ever have worked.  Anyhow the following email contains a
patch to allocate and release this request_queue via the standard helpers.
This has bene shown to fix the issue in testing.

Comments.

-apw

Andy Whitcroft (1):
  aoe: ensure we initialise the request_queue correctly

 drivers/block/aoe/aoe.h    |    2 +-
 drivers/block/aoe/aoeblk.c |    6 +++---
 drivers/block/aoe/aoedev.c |   11 ++++++++++-
 3 files changed, 14 insertions(+), 5 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/