linux-kernel - Re: [PATCH v2 2/2] tracing: Create generic syscall TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A8EF765.9050201@redhat.com>
Date:	Fri, 21 Aug 2009 12:37:09 -0700
From:	Josh Stone <jistone@...hat.com>
To:	Jason Baron <jbaron@...hat.com>
CC:	linux-kernel@...r.kernel.org, fweisbec@...il.com, mingo@...e.hu,
	laijs@...fujitsu.com, rostedt@...dmis.org, peterz@...radead.org,
	mathieu.desnoyers@...ymtl.ca, jiayingz@...gle.com,
	mbligh@...gle.com, lizf@...fujitsu.com
Subject: Re: [PATCH v2 2/2] tracing: Create generic syscall TRACE_EVENTs

On 08/21/2009 10:57 AM, Jason Baron wrote:
>> +TRACE_EVENT_WITH_CALLBACK(sys_enter,
> 
> don't we want to change this to something like 'sys_enter_generic'?
> otherwise, looks good.

Since all of the specific events are named "sys_enter_foo", I thought
that it would be clear that an unadorned "sys_enter" was the more
generic syscall event.  Calling it "sys_enter_generic" seems to me by
convention to mean a system call named "generic".

I don't want to bikeshed this though -- if you still think
"sys_enter_generic" is better, then I'll change it.

Thanks,

Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/