linux-kernel - Re: [PATCH] x86: properly annotate alternatives.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090821200908.GF5356@elte.hu>
Date:	Fri, 21 Aug 2009 22:09:08 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jan Beulich <JBeulich@...ell.com>
Cc:	tglx@...utronix.de, hpa@...or.com, sam@...nborg.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: properly annotate alternatives.c


* Jan Beulich <JBeulich@...ell.com> wrote:

> Some of the NOPs tables aren't used on 64-bits, quite some code and
> data is needed post-init for module loading only, and a couple of
> functions aren't used outside that file (i.e. can be static, and don't
> need to be exported).
> 
> The change to __INITDATA/__INITRODATA is needed to avoid an assembler
> warning.
> 
> Signed-off-by: Jan Beulich <jbeulich@...ell.com>
> Cc: Sam Ravnborg <sam@...nborg.org>
> 
> ---
>  arch/x86/include/asm/alternative.h |    7 ----
>  arch/x86/kernel/alternative.c      |   56 +++++++++++++++++++++----------------
>  include/linux/init.h               |   12 ++++++-
>  3 files changed, 42 insertions(+), 33 deletions(-)

looks like a nice improvement. Sam, what do you think?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/