linux-kernel - Re: [PATCH 1/4] direct-io: unify argument passing by adding a dio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090820170306.93388637.akpm@linux-foundation.org>
Date:	Thu, 20 Aug 2009 17:03:06 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	linux-kernel@...r.kernel.org, jeff@...zik.org,
	benh@...nel.crashing.org, htejun@...il.com, bzolnier@...il.com,
	alan@...rguk.ukuu.org.uk, jens.axboe@...cle.com
Subject: Re: [PATCH 1/4] direct-io: unify argument passing by adding a
 dio_args structure

On Thu, 20 Aug 2009 12:17:36 +0200
Jens Axboe <jens.axboe@...cle.com> wrote:

> The O_DIRECT IO path is a mess of arguments. Clean that up by passing
> those arguments in a dedicated dio_args structure.
> 
> This is in preparation for changing the internal implementation to be
> page based instead of using iovecs.
> 
> ...
>
> +/*
> + * Arguments passwed to aops->direct_IO()

cnat tpye

> + */
> +struct dio_args {
> +	int rw;
> +	const struct iovec *iov;
> +	unsigned long length;
> +	loff_t offset;
> +	unsigned long nr_segs;
> +};

It would be nice to have some documentation.  Especially for that
pestiferous `rw' thing.

nr_segs is associated with the iovec and might as well be contiguous
with it in the struct.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/