linux-kernel - Re: [PATCH] Samsung laptop driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090821233338.GA28241@kroah.com>
Date:	Fri, 21 Aug 2009 16:33:38 -0700
From:	Greg KH <greg@...ah.com>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	linux-kernel@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Soeren Sonnenburg <bugreports@....de>,
	Jérémie Huchet <jeremie@...ah.info>,
	Matthew Garrett <mjg59@...f.ucam.org>
Subject: Re: [PATCH] Samsung laptop driver

On Fri, Aug 21, 2009 at 04:19:52PM -0700, Jesse Barnes wrote:
> On Fri, 21 Aug 2009 15:59:25 -0700
> Greg KH <greg@...ah.com> wrote:
> > Jesse, I don't know how this is going to play with your recently added
> > backlight support for the i915 driver.  As you don't have control over
> > the LEDs and other stuff that this driver is going to support, I think
> > we need some way to keep the i915 driver from messing with the
> > backlight values, don't you think?
> 
> Right, it should be fine.  The i915 driver should only take control and
> provide a backlight when:
>   - no ACPI method is available
>   - no platform method is available (like this one)
>   - backlight is exposed through the GPU or i2c
> 
> So I'm a lot happier now that you've figured out the proper platform
> interface. :)  The test code I sent out earlier didn't work for Mike
> because his VBIOS (properly it turns out) indicated that there was an
> external agent in charge of the backlight.

Great, then all should be good, thanks for letting me know.

Now I wonder if Mike's laptop can be controlled through my new driver,
that would be an interesting test.  I'll ping him about it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/