linux-kernel - Re: [PATCH] Convert MMC subsys drivers to dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200908220713.20637.elendil@planet.nl>
Date:	Sat, 22 Aug 2009 07:13:16 +0200
From:	Frans Pop <elendil@...net.nl>
To:	Marek Vasut <marek.vasut@...il.com>
Cc:	linux-arm-kernel@...ts.infradead.org, nicolas.ferre@...el.com,
	mirq-linux@...e.qmqm.pl, linux-kernel@...r.kernel.org,
	manuel.lauss@...il.com, ppisa@...ron.com, nico@....org,
	maen@...vell.com, s.hauer@...gutronix.de, tony@...mide.com,
	madhu.cr@...com, drzeus@...eus.cx, ben-linux@...ff.org,
	avorontsov@...mvista.com, pierre@...man.eu,
	sdhci-devel@...ts.ossman.eu, saschasommer@...enet.de,
	oakad@...oo.com, ian@...menth.co.uk, HaraldWelte@...tech.com,
	JosephChan@....com.tw
Subject: Re: [PATCH] Convert MMC subsys drivers to dev_pm_ops

Marek Vasut wrote:
> +static struct dev_pm_ops cm710_mmc_pm_ops = {
> +       .suspend = cb710_mmc_suspend,
> +       .resume = cb710_mmc_resume,
> +};

This is almost certainly wrong (same for the other drivers you converted) 
as they now no longer support hibernation, which requires different ops.
Please see: http://lkml.org/lkml/2009/7/25/118.

You also seem to have handled the #ifndef CONFIG_PM case incorrectly.
See http://lkml.org/lkml/2009/8/3/253 for an example how it can be done.

There have already been several threads on lkml discussing this. Please 
search for posts with dev_pm_ops in the subject if you want more 
information.

Also, please CC linux-pm@...ts.linux-foundation.org on patches related to 
this conversion.

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/