| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Aug 2009 10:31:27 +0100 From: Alan Jenkins <sourcejedi.lkml@...glemail.com> To: Mario Limonciello <mario_limonciello@...l.com> Cc: cezary.jackiewicz@...il.com, linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org Subject: Re: [PATCH 3/3] Drop platform sysfs attributes from compal-laptop On 8/21/09, Mario Limonciello <mario_limonciello@...l.com> wrote: > Alan Jenkins wrote: >> On 8/19/09, Mario Limonciello <Mario_Limonciello@...l.com> wrote: >> >> Don't you still need to call platform_device_del() for the fail_rfkill >> case? >> >> > It was previously only called if the sysfs attribute creation failed. > So if it does need to be called, then there was a bug previously there too. Nope, look at it again. > @@ -481,11 +326,7 @@ static int __init compal_init(void) > return 0; > > fail_rfkill: > -fail_platform_device2: > - > - platform_device_del(compal_device); > - > -fail_platform_device1: > +fail_platform_device: > > platform_device_put(compal_device); Without this patch, fail_rfkill falls through to fail_platform_device2, and calls platform_device_del(). With the patch, the call to platform_device_del() is removed, so it will no longer be called for the fail_rfkill case. It's not a pre-existing bug. Regards Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists