linux-kernel - Re: [Patch 1/8] kexec: allow to shrink reserved memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090821171738.304fe91e.akpm@linux-foundation.org>
Date:	Fri, 21 Aug 2009 17:17:38 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Amerigo Wang <amwang@...hat.com>
Cc:	linux-kernel@...r.kernel.org, tony.luck@...el.com,
	linux-ia64@...r.kernel.org, nhorman@...hat.com,
	ebiederm@...ssion.com, andi@...stfloor.org, mingo@...e.hu,
	amwang@...hat.com, bernhard.walle@....de, fenghua.yu@...el.com,
	kamezawa.hiroyu@...fujitsu.com, avorontsov@...mvista.com
Subject: Re: [Patch 1/8] kexec: allow to shrink reserved memory

On Fri, 21 Aug 2009 02:54:25 -0400
Amerigo Wang <amwang@...hat.com> wrote:

> +size_t get_crash_memory_size(void)
> +int shrink_crash_memory(unsigned long new_size)

These aren't particualrly well-chosen global identifiers.  It would be
better if they were called crash_*() or kexec_*(), to make it clear
which subsystem they belong to.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/