linux-kernel - Re: [Patch 1/8] kexec: allow to shrink reserved memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A91EEAA.4070200@redhat.com>
Date:	Mon, 24 Aug 2009 09:36:42 +0800
From:	Amerigo Wang <amwang@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, tony.luck@...el.com,
	linux-ia64@...r.kernel.org, nhorman@...hat.com,
	ebiederm@...ssion.com, andi@...stfloor.org, mingo@...e.hu,
	bernhard.walle@....de, fenghua.yu@...el.com,
	kamezawa.hiroyu@...fujitsu.com, avorontsov@...mvista.com
Subject: Re: [Patch 1/8] kexec: allow to shrink reserved memory

Andrew Morton wrote:
> On Fri, 21 Aug 2009 02:54:25 -0400
> Amerigo Wang <amwang@...hat.com> wrote:
>
>   
>> +size_t get_crash_memory_size(void)
>> +int shrink_crash_memory(unsigned long new_size)
>>     
>
> These aren't particualrly well-chosen global identifiers.  It would be
> better if they were called crash_*() or kexec_*(), to make it clear
> which subsystem they belong to.
>
>   

Ah, good poi nt!

How about crash_get_memory_size() and crash_shrink_memory()?

Thanks!



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/