linux-kernel - Re: [Patch 5/8] ia64: implement crashkernel=auto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A91F57D.10708@redhat.com>
Date:	Mon, 24 Aug 2009 10:05:49 +0800
From:	Amerigo Wang <amwang@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, tony.luck@...el.com,
	linux-ia64@...r.kernel.org, nhorman@...hat.com,
	ebiederm@...ssion.com, andi@...stfloor.org, bernhard.walle@....de,
	fenghua.yu@...el.com, kamezawa.hiroyu@...fujitsu.com,
	avorontsov@...mvista.com
Subject: Re: [Patch 5/8] ia64: implement crashkernel=auto

Ingo Molnar wrote:
>
> e) All the 'else' statements are superflous and make it all harder 
>    to read.
>
> f) 2ULL<<30 should be written as 1ULL<31, to keep things consistent.
>   

Hi,

The reason that I kept 2ULL<<30 instead of 1ULL<<31 is that '1<<30' is 
exactly 1G, so 2ULL<<30 can be easily read as 2G. ;)

> g) A nice comment explaining the purpose and logic wouldnt hurt.
>   

Yup, in fact patch 8/8 has the doc for this, but I will copy that here 
as a comment too.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/