linux-kernel - Re: [PATCH 2/3] inotify: do not BUG on idr entries at inotify destruction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0908241220590.3158@localhost.localdomain>
Date:	Mon, 24 Aug 2009 12:23:19 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Eric Paris <eparis@...hat.com>
cc:	Frans Pop <elendil@...net.nl>, linux-kernel@...r.kernel.org,
	linux-fs-devel@...r.kernel.org, zdenek.kabelac@...il.com,
	christoph.thielecke@....de, akpm@...ux-foundation.org,
	viro@...iv.linux.org.uk, grant.wilson@....co.uk,
	mikko.cal@...il.com
Subject: Re: [PATCH 2/3] inotify: do not BUG on idr entries at inotify
 destruction

On Mon, 24 Aug 2009, Eric Paris wrote:
> 
> You suspect correctly.  :(  I'll fix in my tree before I request a
> pull....

Can you change the WARN() to a WARN_ONCE() too. 

Generally, we prefer the "ONCE" variant if there isn't some intrisic 
reason why we'd want to know about each event. If there is some load that 
triggers this, do you care about _how_many_times_ it happens, or about the 
fact that it happens in the first place? In this case, I think it's the 
"happens in the first place" case - once you see it a single time, the 
rest of the reports aren't that interesting.

And using the ONCE thing means that we know it's not going to spam the 
logs.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/