linux-kernel - Re: [Openipmi-developer] [PATCH] char/impi: adding __init macro/ fix of __exit macro location in ipmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4A9204B4.2030800@acm.org>
Date:	Sun, 23 Aug 2009 22:10:44 -0500
From:	Corey Minyard <minyard@....org>
To:	Peter Hüwe <PeterHuewe@....de>
Cc:	Jiri Kosina <trivial@...nel.org>,
	openipmi-developer@...ts.sourceforge.net,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Openipmi-developer] [PATCH] char/impi: adding __init macro/ fix
 of	__exit macro location in ipmi_poweroff.c

This is correct, I'm fine with it going through the trivial tree.  Thanks.

Acked-by: Corey Minyard <minyard@....org>

Peter Hüwe wrote:
> From: Peter Huewe <peterhuewe@....de>
>
> Trivial patch which adds the __init to the module_init function of
> drivers/char/ipmi/ipmy_poweroff.c and corrects the location of __exit for the
> cleanup function.
>
> According to ldd3, page 31 the __exit token hast to be after the return type.
> Or am I getting something wrong here?
>
> Corey, please have a look at the small patch and either pull it through
> your tree, or please ack' it so Jiri can pull it through the trivial tree.
>
> linux version 2.6.31-rc6 - linus git tree, So 23. Aug 01:38:43 CEST 2009
>
> Signed-off-by: Peter Huewe <peterhuewe@....de>
> ---
> diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c
> index a261bd7..2e66b5f 100644
> --- a/drivers/char/ipmi/ipmi_poweroff.c
> +++ b/drivers/char/ipmi/ipmi_poweroff.c
> @@ -691,7 +691,7 @@ static struct ctl_table_header *ipmi_table_header;
>  /*
>   * Startup and shutdown functions.
>   */
> -static int ipmi_poweroff_init(void)
> +static int __init ipmi_poweroff_init(void)
>  {
>  	int rv;
>  
> @@ -725,7 +725,7 @@ static int ipmi_poweroff_init(void)
>  }
>  
>  #ifdef MODULE
> -static __exit void ipmi_poweroff_cleanup(void)
> +static void __exit ipmi_poweroff_cleanup(void)
>  {
>  	int rv;
>  
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> trial. Simplify your report design, integration and deployment - and focus on 
> what you do best, core application coding. Discover what's new with 
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Openipmi-developer mailing list
> Openipmi-developer@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openipmi-developer
>
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/