linux-kernel - [PATCH] : eliminate code duplication in kernel/tracepoint.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Aug 2009 16:16:31 -0700
From:	"Anirban Sinha" <ASinha@...gmasystems.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	<linux-kernel@...r.kernel.org>, "Oleg Nesterov" <oleg@...sign.ru>
Subject: [PATCH] : eliminate code duplication in kernel/tracepoint.c

Hi Ingo:

I was going through the kernel tracepoints work. It's really impressive.
Congratulations! 

The following cleanup popped up immediately. May be you guys have
noticed it already.

Cheers,

Ani


>From 2068b87b9635a66e5e86b8ff4182d96a6e969584 Mon Sep 17 00:00:00 2001
From: Anirban Sinha <asinha@...gmasystems.com>
Date: Mon, 24 Aug 2009 15:52:20 -0700
Subject: Cleanup: eliminate code duplication in kernel/tracepoint.c


Signed-off-by: Anirban Sinha <asinha@...gmasystems.com>
---
 kernel/tracepoint.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
index 1ef5d3a..4840ab6 100644
--- a/kernel/tracepoint.c
+++ b/kernel/tracepoint.c
@@ -554,9 +554,6 @@ int tracepoint_module_notify(struct notifier_block
*self,

        switch (val) {
        case MODULE_STATE_COMING:
-               tracepoint_update_probe_range(mod->tracepoints,
-                       mod->tracepoints + mod->num_tracepoints);
-               break;
        case MODULE_STATE_GOING:
                tracepoint_update_probe_range(mod->tracepoints,
                        mod->tracepoints + mod->num_tracepoints);
--
1.6.4


>From 5e09b156be90b936db9c1977abcc04b5cbb4bd4a Mon Sep 17 00:00:00 2001
From: Anirban Sinha <asinha@...gmasystems.com>
Date: Mon, 24 Aug 2009 15:55:12 -0700
Subject: cleanup: remove redundant break statement.


Signed-off-by: Anirban Sinha <asinha@...gmasystems.com>
---
 kernel/tracepoint.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
index 4840ab6..35eed9c 100644
--- a/kernel/tracepoint.c
+++ b/kernel/tracepoint.c
@@ -557,7 +557,6 @@ int tracepoint_module_notify(struct notifier_block
*self,
        case MODULE_STATE_GOING:
                tracepoint_update_probe_range(mod->tracepoints,
                        mod->tracepoints + mod->num_tracepoints);
-               break;
        }
        return 0;
 }
--
1.6.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/