linux-kernel - Re: [RFC patch 21/32] x86: Add timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090824064309.GA24326@centrinvest.ru>
Date:	Mon, 24 Aug 2009 10:48:25 +0400
From:	"Andrey Panin" <pazke@...trinvest.ru>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, x86 team <x86@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Arjan van de Veen <arjan@...radead.org>,
	Avi Kivity <avi@...hat.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Alok N Kataria <akataria@...are.com>,
	Pan Jacob jun <jacob.jun.pan@...el.com>
Subject: Re: [RFC patch 21/32] x86: Add timer_init to platform

On 233, 08 21, 2009 at 09:31:20 -0000, Thomas Gleixner wrote:
> The timer init code is convoluted with several quirks and the paravirt
> timer chooser. Figuring out which code path is actually taken is not
> for the faint hearted.
> 
> Move the numaq TSC quirk to tsc_pre_init platform function and replace
> the paravirt time chooser and the remaining x86 quirk with a simple
> platform setup function.

> Index: linux-2.6/arch/x86/kernel/visws_quirks.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/visws_quirks.c
> +++ linux-2.6/arch/x86/kernel/visws_quirks.c
> @@ -30,6 +30,7 @@
>  #include <asm/setup.h>
>  #include <asm/apic.h>
>  #include <asm/e820.h>
> +#include <asm/time.h>
>  #include <asm/io.h>
>  
>  #include <linux/kernel_stat.h>
> @@ -53,8 +54,10 @@ int is_visws_box(void)
>  	return visws_board_type >= 0;
>  }
>  
> -static int __init visws_time_init(void)
> +static void __init visws_time_init(void)
>  {
> +	hpet_time_init();

What's the purpose of this line ? It's highly unlikely that there is HPET hidden
somewhere inside VisWs :)


>  	printk(KERN_INFO "Starting Cobalt Timer system clock\n");
>  
>  	/* Set the countdown value */
> @@ -65,12 +68,6 @@ static int __init visws_time_init(void)
>  
>  	/* Enable (unmask) the timer interrupt */
>  	co_cpu_write(CO_CPU_CTRL, co_cpu_read(CO_CPU_CTRL) & ~CO_CTRL_TIMEMASK);
> -
> -	/*
> -	 * Zero return means the generic timer setup code will set up
> -	 * the standard vector:
> -	 */
> -	return 0;
>  }
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/