linux-kernel - Re: [PATCH 1/4] add NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090825133716.GA2656@redhat.com>
Date:	Tue, 25 Aug 2009 09:37:16 -0400
From:	Jason Baron <jbaron@...hat.com>
To:	Paul Mundt <lethal@...ux-sh.org>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org, fweisbec@...il.com,
	mingo@...e.hu, laijs@...fujitsu.com, rostedt@...dmis.org,
	peterz@...radead.org, mathieu.desnoyers@...ymtl.ca,
	jiayingz@...gle.com, mbligh@...gle.com, lizf@...fujitsu.com,
	jistone@...hat.com, tglx@...utronix.de, hpa@...or.com
Subject: Re: [PATCH 1/4] add NR_syscalls define for x86

On Tue, Aug 25, 2009 at 07:05:32AM +0900, Paul Mundt wrote:
> On Mon, Aug 24, 2009 at 05:40:14PM -0400, Jason Baron wrote:
> > Add a NR_syscalls #define for x86. This is used in the syscall events tracing
> > code. Todo: make it dynamic like x86_64
> > 
> > Signed-off-by: Jason Baron <jbaron@...hat.com>
> > 
> > 
> > ---
> >  arch/x86/include/asm/unistd_32.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/x86/include/asm/unistd_32.h b/arch/x86/include/asm/unistd_32.h
> > index 732a307..8deaada 100644
> > --- a/arch/x86/include/asm/unistd_32.h
> > +++ b/arch/x86/include/asm/unistd_32.h
> > @@ -345,6 +345,8 @@
> >  
> >  #ifdef __KERNEL__
> >  
> > +#define NR_syscalls 337
> > +
> Syscalls start at 0 and end at 337, there are 338 syscalls, not 337.
> Hence the off-by-1 that I initially reported. NR_syscalls is always the
> last syscall + 1.

right, as I explained in my 0/4 message, this patch is for the -tip tree,
where 337 is correct, and needs to be adjusted for the -next tree to 338.

thanks,

-Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/