linux-kernel - Re: [PATCH -tip] timekeeping: Fix up read_persistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090825064458.GC14286@elte.hu>
Date:	Tue, 25 Aug 2009 08:44:58 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Paul Mundt <lethal@...ux-sh.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -tip] timekeeping: Fix up read_persistent_clock()
	breakage on sh.


* Paul Mundt <lethal@...ux-sh.org> wrote:

> The recent commit "timekeeping: Increase granularity of
> read_persistent_clock()" introduced read_persistent_clock() rework which
> inadvertently broke the sh conversion:
> 
> 	arch/sh/kernel/time.c:45: error: passing argument 1 of 'rtc_sh_get_time' from incompatible pointer type
> 	distcc[13470] ERROR: compile arch/sh/kernel/time.c on sprygo/32 failed
> 	make[2]: *** [arch/sh/kernel/time.o] Error 1
> 
> This trivial fix gets it working again.
> 
> Signed-off-by: Paul Mundt <lethal@...ux-sh.org>
> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
> Cc: Ingo Molnar <mingo@...e.hu>
> 
> ---
> 
>  arch/sh/kernel/time.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied, thanks Paul!

I'm wondering, why did my cross-build of the SH defconfig in the 
timer tree not catch this? All i get (and got) are these warnings:

/home/mingo/tip/arch/sh/kernel/cpu/clock-cpg.c: In function 'cpg_clk_init':
/home/mingo/tip/arch/sh/kernel/cpu/clock-cpg.c:242: warning: 'arch_init_clk_ops' is deprecated (declared at /home/mingo/tip/arch/sh/include/asm/clock.h:58)
/home/mingo/tip/arch/sh/kernel/cpu/clock-cpg.c: In function 'arch_clk_init':
/home/mingo/tip/arch/sh/kernel/cpu/clock-cpg.c:256: warning: 'cpg_clk_init' is deprecated (declared at /home/mingo/tip/arch/sh/kernel/cpu/clock-cpg.c:237)

and time.o built without errors or warnings:

  CC      arch/sh/kernel/time.o

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/