linux-kernel - Re: Initial work for ar9271

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1251261111.3463.15.camel@Joe-Laptop.home>
Date:	Tue, 25 Aug 2009 21:31:50 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Luis R. Rodriguez" <mcgrof@...il.com>
Cc:	linux-wireless <linux-wireless@...r.kernel.org>,
	linux-kernel@...r.kernel.org,
	Christian Lamparter <chunkeey@....de>,
	Johannes Berg <johannes@...solutions.net>,
	"John W. Linville" <linville@...driver.com>,
	Greg KH <greg@...ah.com>,
	Stephen Chen <Stephen.Chen@...eros.com>,
	Zhifeng Cai <zhifeng.cai@...eros.com>,
	Cliff Holden <Cliff.Holden@...eros.com>,
	Christoph Hellwig <hch@...radead.org>,
	Len Widra <Len.Widra@...eros.com>
Subject: Re: Initial work for ar9271

On Tue, 2009-08-25 at 21:03 -0700, Luis R. Rodriguez wrote:
> If you'd like to work on the
> driver I welcome patches:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/ar9271.git

I think this style ugly because it's non kernel standard.

int func(args)
{
	do {
		[ linear code ...]
		if (err) {
			errorcode = ;
			break;
		}
		[ more linear code ...]
	} while (0);

	if (errorcode) {
		handle()...
		return some_err;
	}

	return 0;
}

It's a bit too much like a try/throw/catch block.

Are patches accepted to convert it to the more
commonly used kernel style using gotos?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/