linux-kernel - Re: [rfc -tip 3/4] x86,apic: fix missed handling of discrete apics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa79d98a0908252322j3b98c4dbs9b45e6f3147496a8@mail.gmail.com>
Date:	Wed, 26 Aug 2009 10:22:22 +0400
From:	Cyrill Gorcunov <gorcunov@...nvz.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	"Maciej W. Rozycki" <macro@...ux-mips.org>
Subject: Re: [rfc -tip 3/4] x86,apic: fix missed handling of discrete apics

On 8/26/09, Ingo Molnar <mingo@...e.hu> wrote:
>
> * Cyrill Gorcunov <gorcunov@...nvz.org> wrote:
>
>> +	if (!cpu_has_apic && (!smp_found_config || disable_apic))
>> +	if (!cpu_has_apic && (!smp_found_config || disable_apic))
>> +	if (cpu_has_apic || (smp_found_config && !disable_apic))
>
> these are now repeating patterns, so that should be moved into a
> helper inline or so.
>
> 	Ingo
>
Absolutely yes. Though i didn't invent more or less convenient name
for this helper. lapic_from_mp perhaps. Have to think. Thanks for
review, Ingo!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/