linux-kernel - Re: [PATCH mmotm] mm: introduce page_lru_base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090826190233.3977.A69D9226@jp.fujitsu.com>
Date:	Wed, 26 Aug 2009 19:17:35 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Hugh Dickins <hugh.dickins@...cali.co.uk>
Cc:	kosaki.motohiro@...fujitsu.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Rik van Riel <riel@...hat.com>,
	Minchan Kim <minchan.kim@...il.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH mmotm] mm: introduce page_lru_base_type fix

> My usual tmpfs swapping loads on recent mmotms have oddly
> aroused the OOM killer after an hour or two.  Bisection led to
> mm-return-boolean-from-page_is_file_cache.patch, but really it's
> the prior mm-introduce-page_lru_base_type.patch that's at fault.
> 
> It converted page_lru() to use page_lru_base_type(), but forgot
> to convert del_page_from_lru() - which then decremented the wrong
> stats once page_is_file_cache() was changed to a boolean.
> 
> Fix that, move page_lru_base_type() before del_page_from_lru(),
> and mark it "inline" like the other mm_inline.h functions.
> 
> Signed-off-by: Hugh Dickins <hugh.dickins@...cali.co.uk>

I'm sorry vmscan related patch bother you.
this is definitely right fix, thak you.
	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>


> ---
> 
>  include/linux/mm_inline.h |   34 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> --- mmotm/include/linux/mm_inline.h	2009-08-21 12:12:42.000000000 +0100
> +++ linux/include/linux/mm_inline.h	2009-08-26 00:39:38.000000000 +0100
> @@ -35,42 +35,42 @@ del_page_from_lru_list(struct zone *zone
>  	mem_cgroup_del_lru_list(page, l);
>  }
>  
> +/**
> + * page_lru_base_type - which LRU list type should a page be on?
> + * @page: the page to test
> + *
> + * Used for LRU list index arithmetic.
> + *
> + * Returns the base LRU type - file or anon - @page should be on.
> + */
> +static inline enum lru_list page_lru_base_type(struct page *page)
> +{
> +	if (page_is_file_cache(page))
> +		return LRU_INACTIVE_FILE;
> +	return LRU_INACTIVE_ANON;
> +}
> +
>  static inline void
>  del_page_from_lru(struct zone *zone, struct page *page)
>  {
> -	enum lru_list l = LRU_BASE;
> +	enum lru_list l;
>  
>  	list_del(&page->lru);
>  	if (PageUnevictable(page)) {
>  		__ClearPageUnevictable(page);
>  		l = LRU_UNEVICTABLE;
>  	} else {
> +		l = page_lru_base_type(page);
>  		if (PageActive(page)) {
>  			__ClearPageActive(page);
>  			l += LRU_ACTIVE;
>  		}
> -		l += page_is_file_cache(page);
>  	}
>  	__dec_zone_state(zone, NR_LRU_BASE + l);
>  	mem_cgroup_del_lru_list(page, l);
>  }
>  
>  /**
> - * page_lru_base_type - which LRU list type should a page be on?
> - * @page: the page to test
> - *
> - * Used for LRU list index arithmetic.
> - *
> - * Returns the base LRU type - file or anon - @page should be on.
> - */
> -static enum lru_list page_lru_base_type(struct page *page)
> -{
> -	if (page_is_file_cache(page))
> -		return LRU_INACTIVE_FILE;
> -	return LRU_INACTIVE_ANON;
> -}
> -
> -/**
>   * page_lru - which LRU list should a page be on?
>   * @page: the page to test
>   *



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/