linux-kernel - [RFC][PATCH -rt] sched: fully ignore RT tasks for CFS load-balancing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1251297875.18584.5.camel@twins>
Date:	Wed, 26 Aug 2009 16:44:35 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: [RFC][PATCH -rt] sched: fully ignore RT tasks for CFS
 load-balancing

Since -rt runs IRQs and SoftIRQs as RT tasks and load-balancing is done
from softirq context, there is always at least one RT task (and very
likely multiple) running when we balance.

The current (and totally broken) interaction between RT tasks and CFS
load-balancing makes it so that we'll try to evacuate a significant
amount of tasks due to RT tasks being runnable.

Solve this in another broken way by not accounting RT tasks at all.

This will likely break another class of cases, but until we can properly
fix this, we might as well do this.

Chucked-on-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
---
 kernel/sched_rt.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index adcbc68..385d31f 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -926,8 +926,6 @@ static void enqueue_task_rt(struct rq *rq, struct
task_struct *p, int wakeup)
 
 	if (!task_current(rq, p) && p->rt.nr_cpus_allowed > 1)
 		enqueue_pushable_task(rq, p);
-
-	inc_cpu_load(rq, p->se.load.weight);
 }
 
 static void dequeue_task_rt(struct rq *rq, struct task_struct *p, int
sleep)
@@ -942,8 +940,6 @@ static void dequeue_task_rt(struct rq *rq, struct
task_struct *p, int sleep)
 	dequeue_rt_entity(rt_se);
 
 	dequeue_pushable_task(rq, p);
-
-	dec_cpu_load(rq, p->se.load.weight);
 }
 
 /*

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/